Date: Wed, 28 Jul 1999 10:40:56 +0100 From: Lack Mr G M To: Samba List Subject: Date/time bug in 2.0.5a? Message-ID: <379ED028.FC9DAB17@ggr.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Is this just me???? Just installed 2.0.5a for testing. Copying files (using explorer) from NT to Samba-2.0.5a (Solaris2.6 *and* Irix6.5) fails to copy the date/time stamp correctly (1.9.18p7 is fine, from the same NT system). 24/06/1999 11:59 (on NT) => 25/06/1999 17:14 (Samba) 25/06/1999 17:00 (on NT) => 25/06/1999 17:09 (Samba) (Yes, that is one 24th and three 25ths of June...) No special configure options used beyond using cc (not gcc) as the compiler for both systems. (NOTE: Just checked with 2.0.4b on Solaris. The same problem exists there.] Copying these files back form Unix to NT does preserve the dates Ok. ------------------------------ Date: Thu, 29 Jul 1999 12:05:20 +0100 From: Lack Mr G M To: Samba List Subject: Re: Date/time bug in 2.0.5a? Message-ID: <37A03570.298F8D88@ggr.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit > Is this just me???? It wasn't... > 24/06/1999 11:59 (on NT) => 25/06/1999 17:14 (Samba) > 25/06/1999 17:00 (on NT) => 25/06/1999 17:09 (Samba) The patch (from the Samba Team) is: =================================================================== RCS file: /data/cvs/samba/source/smbd/trans2.c,v retrieving revision 1.105.2.22.2.2 diff -u -r1.105.2.22.2.2 trans2.c --- trans2.c 1999/07/14 13:22:05 1.105.2.22.2.2 +++ trans2.c 1999/07/28 19:08:42 @@ -1664,7 +1664,7 @@ tvs.actime = interpret_long_date(pdata+8); /* write time + changed time, combined. */ - tvs.modtime=MAX(interpret_long_date(pdata+16), + tvs.modtime=MIN(interpret_long_date(pdata+16), interpret_long_date(pdata+24)); #if 0 /* Needs more testing... */ --------- Gordon Lack --------------- gml4410@ggr.co.uk ------------ This message *may* reflect my personal opinion. It is *not* intended to reflect those of my employer, or anyone else.